Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix benchmarks #926

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

alon-dotan-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.46%. Comparing base (2798020) to head (aca20e4).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #926   +/-   ##
=======================================
  Coverage   91.46%   91.46%           
=======================================
  Files          94       94           
  Lines       13712    13712           
  Branches    13712    13712           
=======================================
  Hits        12541    12541           
  Misses       1056     1056           
  Partials      115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: bfc5521 Previous: cd8b37b Ratio
merkle throughput/simd merkle 30003934 ns/iter (± 385806) 13712527 ns/iter (± 579195) 2.19

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants