relation tracker #912
Merged
relation tracker #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
This change is |
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #912 +/- ##
==========================================
+ Coverage 90.55% 91.44% +0.89%
==========================================
Files 94 94
Lines 13578 13578
Branches 13578 13578
==========================================
+ Hits 12295 12417 +122
+ Misses 1169 1046 -123
- Partials 114 115 +1 ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 0d41284 | Previous: cd8b37b | Ratio |
|---|---|---|---|
iffts/simd ifft/22 |
12967410 ns/iter (± 189979) |
6306399 ns/iter (± 210024) |
2.06 |
merkle throughput/simd merkle |
32261634 ns/iter (± 504816) |
13712527 ns/iter (± 579195) |
2.35 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @shaharsamocha7
Alon-Ti
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)
ohad-starkware
changed the base branch from
ohad/relation_summary
to
graphite-base/912
ohad-starkware
force-pushed
the
ohad/state_machine_tracker
branch
from
748e42b to
0d41284
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.