-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update channel and change group_by to chunk_by #462
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson)
src/lib.rs
line 8 at r1 (raw file):
new_uninit, slice_group_by, stdsimd,
Don't we need this?
Code quote:
stdsimd,
00596e4
to
f111623
Compare
f111623
to
04a611a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 15 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)
src/lib.rs
line 8 at r1 (raw file):
Previously, shaharsamocha7 wrote…
Don't we need this?
My bad. Feature goes by "stdarch_x86_avx512" in the newer channel. Also there are some new lints hence the added changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 14 files at r2, all commit messages.
Reviewable status: 2 of 15 files reviewed, 4 unresolved discussions (waiting on @andrewmilson)
Cargo.toml
line 27 at r2 (raw file):
nonstandard-style = "deny" rust-2018-idioms = "deny" unused = "deny"
This allows unused imports?
Code quote:
unused = "deny"
src/commitment_scheme/mixed_degree_merkle_tree.rs
line 558 at r2 (raw file):
let second_column_queries = vec![3, 7]; let third_column_queries = vec![1, 2]; let queries = vec![
?
Code quote:
vec!
src/commitment_scheme/utils.rs
line 256 at r2 (raw file):
) where F: IntoSlice<H::NativeType>, {
Why do we have those changes?
where statements are not supported?
Code quote:
) where
F: IntoSlice<H::NativeType>,
{
src/core/fri.rs
line 102 at r2 (raw file):
// TODO(andrew): Make folding factor generic. // TODO(andrew): Fold directly into FRI layer to prevent allocation. fn fold_circle_into_line<F: Field>(
related to this pr?
Code quote:
: Field
This change is