Skip to content

bug: DAOSpace MemberProposalPlugin execute_proposal with empty image_data cause join_member fail #188

@yubing744

Description

@yubing744

Bug Report

Starcoin Framework version:

commit_id: 4ebe51b
branch: main

Current behavior:

Create a proposal for adding members. If the incoming image_data is an empty string, it will cause the proposal to fail to add members after the proposal is voted successfully. Error: ERR_CANOT_EMPTY

Expected behavior:

After the proposal is voted successfully, members are added successfully.

Steps to reproduce:

  call 0x1::MemberProposalPlugin::create_proposal_entry
  params: [
          $daoType,
          'Apply add 0x76Ac08692318fd25E2E5e5c37662530B as member',
          '0x76Ac08692318fd25E2E5e5c37662530B',
          "",
          "ipfs://xxxxxx",
          100,
          0
  ]

Related code:

DAOSpace::member_offer(&member_cap, member, Option::some(image_data), Option::some(image_url) , init_sbt);

Other information:

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions