authrevproxy byte object

[hadjigc]

Hi, I Installed the TensorBoard app in OnDemand 1.7 and had some issues getting the authrevproxy script working properly initially.
The issues seem to be due to a newer version of Twisted with Python3 using byte objects instead of strings.
The following line wasn't working:

cookie = request.getCookie('_ood_token_' + ood_session_id)

The request.received_cookies object which the function searches was returning a byte object dict
so I had to change it to the following

cookie = request.getCookie(str('_ood_token_' + ood_session_id).encode())

And also decode the cookie afterwards:
if cookie.decode() == ood_token and cookie != None:

The last argument in the return function also needed to be a byte object:

                return proxy.ReverseProxyResource(self.host,
                                                  self.port,
                                                  b'/' + path)

Hopefully this helps if someone has trouble getting the app working.

Regards,
Chris

[kcgthb]

Hi Chris,

Thanks for the note for suggesting those fixes. Twisted has changed significantly since we wrote this, so I guess an update to support new versions is probably warranted, indeed!