Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the wrong loss func was chosen at evaluation #93

Open
peterjc123 opened this issue Jan 18, 2024 · 2 comments · May be fixed by stanford-futuredata/Megatron-LM#6
Open

the wrong loss func was chosen at evaluation #93

peterjc123 opened this issue Jan 18, 2024 · 2 comments · May be fixed by stanford-futuredata/Megatron-LM#6

Comments

@peterjc123
Copy link

The loss func is always moe_loss_func as can be seen here. But the loss is only calculated when training, which can be seen here. We should fallback to the original loss func during evaluation.
@tgale96
Copy link
Contributor

tgale96 commented Jan 18, 2024

That sounds reasonable to me! We'd be happy to take a PR if you'd like to fix this in our Megatron-LM fork!

@peterjc123 peterjc123 linked a pull request Jan 19, 2024 that will close this issue
Open
@peterjc123
Copy link
Author

@tgale96 I've put up a fix. Please take a look when you have time. stanford-futuredata/Megatron-LM#6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes for eval peterjc123/Megatron-LM
2 participants
@peterjc123 @tgale96