Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[signer] Improve DEFAULT_BLOCK_PROPOSAL_MAX_AGE_SECS #5566

Open
jferrant opened this issue Dec 12, 2024 · 1 comment
Open

[signer] Improve DEFAULT_BLOCK_PROPOSAL_MAX_AGE_SECS #5566

jferrant opened this issue Dec 12, 2024 · 1 comment
Labels
enhancement Iterations on existing features or infrastructure. optimization Update speed, efficiency, or quality of a feature.

Comments

@jferrant
Copy link
Collaborator

It would be good to have a better default for DEFAULT_BLOCK_PROPOSAL_MAX_AGE_SECS that is some small multiple of the expected RTT for the peer network. Figure out what the current estimated RTT is go from there.

@jferrant jferrant added the enhancement Iterations on existing features or infrastructure. label Dec 12, 2024
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Dec 12, 2024
@jcnelson jcnelson added the optimization Update speed, efficiency, or quality of a feature. label Dec 17, 2024
@jcnelson
Copy link
Member

The consequences of leaving this as-is are that it's possible that the node will consider a stale block-proposal which will ultimately be rejected, but this is unlikely because there are other checks in the node that prevent stale messages from getting to this logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Iterations on existing features or infrastructure. optimization Update speed, efficiency, or quality of a feature.
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

3 participants
@jcnelson @jferrant and others