Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: New signer state machine for each input #1202

Closed
1 task
djordon opened this issue Jan 10, 2025 · 0 comments · Fixed by #1209
Closed
1 task

[Feature]: New signer state machine for each input #1202

djordon opened this issue Jan 10, 2025 · 0 comments · Fixed by #1209
Assignees
Labels
key rotation The functionality to rotate a private key for a signer in sBTC-v1.

Comments

@djordon
Copy link
Collaborator

djordon commented Jan 10, 2025

Feature - New signer state machine for each input

1. Description

Whenever a signer gets a sign request over a particular message, the signers create a state machine if its for a transaction ID that they have never seen before. But this ties the signing shares to transaction when it should be tied to the input that is being signed since a transaction can contained inputs locked by different keys.

1.1 Context & Purpose

We need to support running deposits locked with different aggregate keys.

2. Technical Details:

When a signer receives a NonceRequest message they should create a new state machine associated with the message that they being are asked to sign. Then, when the signer receives a subsequent SignatureShareRequest message, they provide their signature shares if a state machine exists for the message to be signed and exit otherwise. At the end of they should delete the state machine from memory. This is similar to the current flow, but oriented around messages instead of txids.

2.1 Acceptance Criteria:

  • The signers create new state machines for each message that they sign

3. Related Issues and Pull Requests (optional):

@djordon djordon added the key rotation The functionality to rotate a private key for a signer in sBTC-v1. label Jan 10, 2025
@djordon djordon added this to the sBTC: Key rotation milestone Jan 10, 2025
@djordon djordon self-assigned this Jan 10, 2025
@djordon djordon added this to sBTC Jan 10, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Jan 10, 2025
@djordon djordon moved this from Needs Triage to In Progress in sBTC Jan 10, 2025
@djordon djordon moved this from In Progress to In Review in sBTC Jan 14, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in sBTC Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
key rotation The functionality to rotate a private key for a signer in sBTC-v1.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant