feat: add config params for dkg-rerun bitcoin block height and target rounds #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
cylewitruk
added
sbtc signer binary
…uration-variable-for-second-dkg
cylewitruk
changed the title
matteojug
reviewed
Jan 13, 2025
|
@djordon I left the default target to 1 -- it means an extra config param for signers when we do the 2nd round, but they need to add the min block height anyway. It just feels better for me, that the default settings |
matteojug
approved these changes
Jan 14, 2025
cylewitruk
deleted the
1201-feature-add-bitcoin-block-height-configuration-variable-for-second-dkg
branch
👍🏽 yeah that does feel better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1201
Closes: #1207
Changes
Adds the configuration parameter
dkg_rerun_bitcoin_height(don't love the name) anddkg_rounds_targetin preparation for #1199 and #1200.I made this optional for now (contrary to #1201 requesting required) because I'm not sure how we want this to behave when it comes to devenv etc. -- required would mean that devenv needs to run two DKG's, maybe we don't want that? So I can change it to required after we discuss the implications if we want.
Testing Information
Checklist: