Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Avoid skipping the rest of the block if we err when processing an event in new block handler #1182

Open
matteojug opened this issue Jan 3, 2025 · 0 comments · May be fixed by #1198
Open

[Bug]: Avoid skipping the rest of the block if we err when processing an event in new block handler #1182

matteojug opened this issue Jan 3, 2025 · 0 comments · May be fixed by #1198
Assignees
@matteojug
Labels
bug Something isn't working
Milestone
sBTC: Key rotation

Comments

@matteojug
Copy link
Collaborator

Chore - Avoid skipping the rest of the block if we err when processing an event in new block handler

1. Description

In the new block handler, we currently return at the first error when processing the events:

sbtc/signer/src/api/new_block.rs

Lines 161 to 164 in e4c6b5f

Err(error) => {
tracing::error!(%error, "got an error when transforming the event ClarityValue");
return StatusCode::OK;
}

Doing so, we will skip all the successive events in the same block. Instead, we should just continue (or return an err and stall the process?).
@matteojug matteojug added chore bug Something isn't working and removed chore labels Jan 3, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Jan 3, 2025
@djordon djordon moved this from Needs Triage to Todo in sBTC Jan 3, 2025
@djordon djordon added this to the sBTC: Key rotation milestone Jan 3, 2025
@matteojug matteojug self-assigned this Jan 9, 2025
@matteojug matteojug moved this from Todo to In Progress in sBTC Jan 9, 2025
@matteojug matteojug linked a pull request Jan 9, 2025 that will close this issue
Open
4 tasks
@matteojug matteojug moved this from In Progress to In Review in sBTC Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matteojug matteojug

Labels
bug Something isn't working
Projects
sBTC
Status: In Review
Milestone
sBTC: Key rotation
Development

Successfully merging a pull request may close this issue.

fix: continue processing events in new block after unknown events stacks-network/sbtc
2 participants
@matteojug @djordon