We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the new block handler, we currently return at the first error when processing the events:
return
sbtc/signer/src/api/new_block.rs
Lines 161 to 164 in e4c6b5f
Doing so, we will skip all the successive events in the same block. Instead, we should just continue (or return an err and stall the process?).
continue
The text was updated successfully, but these errors were encountered:
matteojug
Successfully merging a pull request may close this issue.
Chore - Avoid skipping the rest of the block if we err when processing an event in new block handler
1. Description
In the new block handler, we currently
return
at the first error when processing the events:sbtc/signer/src/api/new_block.rs
Lines 161 to 164 in e4c6b5f
Doing so, we will skip all the successive events in the same block. Instead, we should just
continue
(or return an err and stall the process?).The text was updated successfully, but these errors were encountered: