Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Consider activating Rust integer overflow protection #1173

Open
evonide opened this issue Dec 20, 2024 · 1 comment
Open

[Feature]: Consider activating Rust integer overflow protection #1173

evonide opened this issue Dec 20, 2024 · 1 comment

Comments

@evonide
Copy link

evonide commented Dec 20, 2024

Feature - Consider activating Rust integer overflow protection

1. Description

We should measure the impact of activating Rust integer overflow checks as per https://doc.rust-lang.org/cargo/reference/profiles.html#overflow-checks. This can be activated through a config change in https://github.com/stacks-network/sbtc/blob/main/Cargo.toml.

It's recommended to activate this if the resulting performance tradeoff can be accepted.

Note: We should ensure this will cover WSTS as well.

@djordon
Copy link
Contributor

djordon commented Dec 20, 2024

Oh I thought that it panicked by default, but it appears that it wraps by default. Yeah we should do this.

@djordon djordon added the chore label Dec 20, 2024
@djordon djordon added this to sBTC Dec 20, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Dec 20, 2024
@djordon djordon added this to the sBTC: Key rotation milestone Dec 20, 2024
@djordon djordon moved this from Needs Triage to Todo in sBTC Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

2 participants