You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The no-rolling-update-strategy rule is looking for a DeploymentLike object to have a strategy.type field matching RollingUpdate|Rolling.
However the rule is useful for ensuring we don't set a type of Recreate.
I think this rule would be better revised to consider a missing value as being a pass.
To Reproduce
Enable no-rolling-update-strategy.
Lint two deploymentLike objects. One that does not set a strategy. One that sets RolllingUpdate explicitly.
They are equivalent in effect, and so should be treated the same.
Describe the bug
The
no-rolling-update-strategy
rule is looking for a DeploymentLike object to have astrategy.type
field matchingRollingUpdate|Rolling
.However the default value for this field is
RollingUpdate
making specifying it redundant: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategyHowever the rule is useful for ensuring we don't set a type of
Recreate
.I think this rule would be better revised to consider a missing value as being a pass.
To Reproduce
Enable
no-rolling-update-strategy
.Lint two deploymentLike objects. One that does not set a strategy. One that sets RolllingUpdate explicitly.
They are equivalent in effect, and so should be treated the same.
Sample YAML input
.kube-linter.yaml
sample.yaml
Expected behavior
Only app1 should be identifies as violating this linting rule. app2 and app3 are directly equivalent to each other.
Additional context
The text was updated successfully, but these errors were encountered: