feat(core): Allow multiple indexes in a single AttachStep #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravanscafi
commented
Mar 31, 2024
| childRef.current?.measureInWindow((x, y, width, height) => { | ||
| changeSpot({ height, width, x, y }); | ||
| }); | ||
| } | ||
| }, [changeSpot, current, index]); | ||
| }, [changeSpot, current, index.toString()]); |
There was a problem hiding this comment.
This is needed to compare arrays, otherwise, they will always differ and useEffect will be called infinite times.
ravanscafi
commented
Mar 31, 2024
| @@ -24,7 +24,7 @@ function TestScreen(): React.ReactElement { | |||
| <Text>{"Test Tour 1"}</Text> | |||
| </AttachStep> | |||
|
|
|||
| <AttachStep index={1}> | |||
| <AttachStep index={[1]}> | |||
There was a problem hiding this comment.
this ensures using an array of indexes will break no other behaviors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Sorry for proposing this feature directly as a Pull Request, but I needed it for my own Tour and thought it would be nice to contribute to the project :)
Let me know what you think and how we can make it better!