Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating CI to new get-tested version (v0.1.7.0) #191

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

DavidMazarro
Copy link
Member

I opened this issue Kleidukos/get-tested#32 in the get-tested repo with a feature request to support setting the specific version of the OS runner we want to run; prior to the v0.1.7.0 version, the runners were all set to *-latest. Thanks to @Kleidukos' work, this is now supported in the most recent v0.1.7.0 version of get-tested. This PR changes our workflow to this new version of the action.

@DavidMazarro DavidMazarro self-assigned this Mar 8, 2024
@DavidMazarro
Copy link
Member Author

I've set the macos-version to 14 for now with two purposes:

  1. Testing that the new version of the action works as expected
  2. Out of curiosity, testing the Apple Silicon runner (and see if the library builds successfully)
    After that, I'll revert it to macos-latest. It would be interesting to ensure compatibility with Apple Silicon, but the runner is still in beta, so I don't think it's advisable using it for now.

Previously I had only updated the version of the action itself
@DavidMazarro DavidMazarro force-pushed the new-get-tested-version branch from 4faa93e to 4edeb32 Compare March 8, 2024 10:04
@DavidMazarro
Copy link
Member Author

Probably not a big surprise, but the Apple Silicon macOS runner doesn't play nicely with GHC 8; it complains about the version of LLVM. When run just with GHC 9.6 and 9.8, it works fine and the library builds without issues.

After testing that, I have reverted back to the latest runner.

@DavidMazarro DavidMazarro force-pushed the new-get-tested-version branch from de3871e to 99e7c0c Compare March 8, 2024 10:26
@DavidMazarro
Copy link
Member Author

DavidMazarro commented Mar 8, 2024

I think the CI is currently failing because some dependency cache for the Apple Silicon runner was created, and now the macos-latest runner is having issues building dependencies with that dependency cache. I'll take a look into it.

Edit: fixed (by invalidating the ill cache).

@DavidMazarro DavidMazarro merged commit adb6062 into main Mar 8, 2024
10 of 14 checks passed
@DavidMazarro DavidMazarro deleted the new-get-tested-version branch March 8, 2024 14:37
@CristhianMotoche
Copy link
Collaborator

@all-contributors please add @DavidMazarro for code

Copy link
Contributor

@CristhianMotoche

I've put up a pull request to add @DavidMazarro! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants