Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of operating systems #7

Open
m-mohr opened this issue Dec 13, 2021 · 3 comments
Open

List of operating systems #7

m-mohr opened this issue Dec 13, 2021 · 3 comments
Assignees

Comments

@m-mohr
Copy link
Contributor

m-mohr commented Dec 13, 2021

The OS list is taken from Python, but there are some things that we should think about:

  1. For example, in R the "OS.type" constant is only one of "UNIX" (which covers both mac and linux derivates) or "windows". How does that translate?
  2. In node it looks similar to Python: https://nodejs.org/api/process.html#process_process_platform but there are more values. Should we extent the list a bit?
  3. Julia also has a variation: https://docs.julialang.org/en/v1/manual/handling-operating-system-variation/ etc - A quick survey would be good to get to a better list of OS
  4. cygwin is a "strange" OS and a special case. How should other similar cases be handled? Thinking about WSL, Wine etc.
@m-mohr
Copy link
Contributor Author

m-mohr commented Dec 14, 2021

@duckontheweb (No offence, just curious....) Was it intentional that you released without discussing the open issue(s)?

@duckontheweb
Copy link
Contributor

Sorry, @m-mohr! I was working quickly to get a published version out and forgot to address this prior to publishing. The JSON schema is actually not checking for an enum on this property, so any string value will validate correctly. I will put in a PR that changes the description in the README to be a strong recommendation to be in line with the schema and I will also do a survey of some standard value (as you suggested) so we can get some more feedback on those).

@m-mohr
Copy link
Contributor Author

m-mohr commented Dec 15, 2021

👍 Good that there's no enum restriction (yet) so that it won't be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants