Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify bbox and geometry field documentation #2

Open
duckontheweb opened this issue Jul 1, 2021 · 0 comments
Open

Clarify bbox and geometry field documentation #2

duckontheweb opened this issue Jul 1, 2021 · 0 comments

Comments

@duckontheweb
Copy link
Collaborator

The current "bbox and geometry" section of the README seems pretty confusing.

  • ml-aoi Multiple items may reference the same label and image item by scoping the bbox and geometry fields. TODO: Better describe scoping of overlap between raster and label items?

We should provide a more thorough description of what this means along with some examples

ml-aoi Items in the same Collection should never have overlapping geometry fields.

Is this really a requirement? What if we had a label + source imagery pair from a scene taken on 2021-01-01 and then another label + source imagery pair from a scene taken on 2021-01-02 over the same area? It seems like those would represent valid and distinct ML AOI Items with overlapping geometries.

  • ml-aoi Items bbox field may overlap when they belong to different ml-aoi:split set.

The same logic would apply here as well; it seems there could be valid cases where we have Items in the same split with overlapping bboxes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant