Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contracts coverage #137

Open
9 tasks
a17 opened this issue May 15, 2024 · 0 comments
Open
9 tasks

Improve contracts coverage #137

a17 opened this issue May 15, 2024 · 0 comments
Assignees
Labels
META ISSUE Set of issues, pull requests and requirements

Comments

@a17
Copy link
Member

a17 commented May 15, 2024

Here we collect all the uncovered areas in the code base with a description of how to cover them.

Core

  • ...

Strategies

  • DefiEdgeQuickSwapMerklFarmStrategy
    • _normalise, _getChainlinkPrice: test with asset that have decimals > 18
    • _calculateShares: test with totalShares == 0 DefiEdge underlying ALM or make such underlyings unsupportable
    • _getPriceInUSD: test with not _isBase asset that need chainlink price
  • GammaQuickSwapMerklFarmStrategy
    • _previewDepositAssets: try to write fuzzing test or something like it
    • _assetsAmounts: read on empty vault in test
  • GammaRetroMerklFarmStrategy
    • initVariants: test with not active farm
    • _previewDepositAssets: try to write fuzzing test or something like it
    • _assetsAmounts: read on empty vault in test
  • IchiQuickSwapMerklFarmStrategy
    • getAssetsProportions: test with other underlyings
  • ...
@a17 a17 added the META ISSUE Set of issues, pull requests and requirements label May 15, 2024
@a17 a17 changed the title Improve coverage Improve contracts coverage Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
META ISSUE Set of issues, pull requests and requirements
Projects
Development

No branches or pull requests

2 participants