Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of OSCommand in test suites #1147

Open
gvoskuilen opened this issue Oct 1, 2024 · 0 comments
Open

Fix use of OSCommand in test suites #1147

gvoskuilen opened this issue Oct 1, 2024 · 0 comments

Comments

@gvoskuilen
Copy link
Contributor

The "public" API for test suites is included in sst_unittest.py and sst_unittest_support.py. sst-unittest's os_simple_command() function provides some of the underlying OSCommand functionality but not enough and so test suites are using OSCommand directly. Either OSCommand() needs to be part of the sst-unittest API or unittest needs a more functional wrapper for it.

E.g.,
os_command(os_cmd, output_file_path=None, error_file_path=None, set_cwd=None, timeout_sec=60)
The function should return OSCommandResult (test suites are using rtn.result, rtn.output, rtn.error).

Also include ability to pass env vars once that is added to OSCommand.
Deprecate os_simple_command() in favor of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants