Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state.get().add is not a function #28

Open
liangklfangl opened this issue May 23, 2017 · 1 comment
Open

state.get().add is not a function #28

liangklfangl opened this issue May 23, 2017 · 1 comment
Labels

Comments

@liangklfangl
Copy link

If we install [email protected] and [email protected] manually, then next code fragment will throw:

function updatingItem(state, action) {
  return state.set('updating', state.get('updating').push(action.itemId));
}

But, if we downgrade to [email protected], everything works ok. This error appears using server-rending~

@sslotsky sslotsky added the bug label Aug 3, 2017
@sslotsky
Copy link
Owner

sslotsky commented Aug 3, 2017

Thanks for reporting this. Really not sure how I missed it.

This package is actually moving. Technically, it has already moved, but I have some actions left to take before I can deprecate this one. That includes adding better documentation for the new package.

I think the best solution for this repo is to update the peer dependencies in package.js to reflect the range of working versions. Then I can look into extending that range for the new package. It would be really great if you'd be willing to do two things:

  1. Submit a PR to update the peer dependencies
  2. Open this same issue in the new repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants