Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when trying to edit repository info #6

Open
stlutz opened this issue Nov 13, 2020 · 2 comments
Open

Error when trying to edit repository info #6

stlutz opened this issue Nov 13, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@stlutz
Copy link

stlutz commented Nov 13, 2020

When in Monticello, right-clicking the repository and selecting edit repository info produces the attached error message.

MessageNotUnderStood: FSReference>>pathName

@j4yk j4yk added the bug Something isn't working label Nov 13, 2020
@j4yk
Copy link
Collaborator

j4yk commented Nov 13, 2020

This is another FileSystem vs. FileDirectory incompatibility. The method from MCDirectoryRepository expects a FileDirectory, but TonelRepository uses an FSReference in the place.

@j4yk
Copy link
Collaborator

j4yk commented Nov 13, 2020

There are two methods in FileDirectory which have the same implementation: pathName and fullName. The latter has an equivalent implementation in FSReference already, while the former does not have one yet.

So either we litter FSReference with a compatibility implementation of pathName, or we override MCDirectoryRepository>>#creationTemplate in TonelRepository (duplicating most of the code due to the composition of that method), or we propose to change MCDirectoryRepository>>#creationTemplate in Monticello to use fullName instead of pathName.

Opinions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants