New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Dictionary>>isHealthy #7

Open

j4yk opened this issue Apr 30, 2022 · 2 comments · May be fixed by #8

j4yk commented Apr 30, 2022

These methods send #isHealthy, but it is not implemented in Squeak:

Dictionary>>#stonPostReferenceResolution
Set>>#stonPostReferenceResolution
STONReaderTest>>#testDictionaryWithIndirectReferenceKeys
STONReaderTest>>#testDictionaryWithReferenceKeys
STONReaderTest>>#testSetWithIndirectReferenceElements
STONReaderTest>>#testSetWithReferenceElements

Author

j4yk commented Apr 30, 2022

@fniephaus Looks like you already added that on https://github.com/fniephaus/ston/tree/fniephaus-patch-3

How do you suggest we best integrate it? Merge the branch or "cherry-pick" the methods?

Member

fniephaus commented Apr 30, 2022

Feel free to cherry-pick, seems to be the easiest solution.

j4yk linked a pull request

that will close this issue

Import STON-Squeak-Core extension package from fniephaus/ston #8

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment