Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to merge upstream #6

Open
marceltaeumel opened this issue Apr 22, 2022 · 1 comment
Open

How to merge upstream #6

marceltaeumel opened this issue Apr 22, 2022 · 1 comment

Comments

@marceltaeumel
Copy link
Member

Here is a change-set that makes the current "master" in upstream compatible with Squeak6.0alpha.

fix-squeak-ston.5.cs.txt

@marceltaeumel
Copy link
Member Author

Here is some extra documentation for the upstream maintainers:

Maybe you can infer a few new ideas on how to improve modularity and extension points upstream. For example, the use of STONZnUrl and STONFileReference in "STON-Core" seems unnecessary. Also their base class not being Object. The package "STON-Extensions" might be a better fit. Same for the extensions in SmallDictionary.

Since there is a Pharo-specific "STON-Extensions" package, it might be beneficial to mirror this structure in test packages. There is currently only "STON-Tests". A few tests might benefit from being extracted into a "STON-Tests-Extensions" for example. Then I could also add a "STON-Tests-ExtensionsForSqueak".

The rather small package "STON-Text support" could be merged into "STON-Core" or "STON-Extensions" as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant