Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ViewEnvironment (esp ViewRegistry) to support merging values #135

Open
rjrjr opened this issue Apr 28, 2020 · 1 comment
Open

Allow ViewEnvironment (esp ViewRegistry) to support merging values #135

rjrjr opened this issue Apr 28, 2020 · 1 comment
Labels
enhancement New feature or request kotlin swift

Comments

@rjrjr
Copy link
Collaborator

rjrjr commented Apr 28, 2020

In kotlin, it's surprising that that envA + envB stomps A's ViewRegistry entirely. It's not hard to work around, but it's tedious.

We should think about providing a general mechanism to allow entries to merge, and make ViewRegistry use it.
@rjrjr rjrjr added the enhancement New feature or request label Apr 28, 2020
@rjrjr
Copy link
Collaborator Author

rjrjr commented May 4, 2022

Addressed in kotlin by square/workflow-kotlin#737

@rjrjr rjrjr transferred this issue from square/workflow May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request kotlin swift
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zach-klippenstein @rjrjr