New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validateCommandRequest should check QR code size #230

Open

alokmenghrajani opened this issue Aug 19, 2020 · 0 comments

Contributor

alokmenghrajani commented Aug 19, 2020

https://github.com/square/subzero/blob/master/java/shared/src/main/java/com/squareup/subzero/shared/SubzeroUtils.java#L295 does not check if the resulting request (and corresponding response) will fit in a QR code.

We have constants (https://github.com/square/subzero/blob/master/java/shared/src/main/java/com/squareup/subzero/shared/Constants.java#L30) we can use (or just calculate the request/response sizes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment