Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkstyle rules for Square's code style? #9

Open
a11n opened this issue Mar 11, 2015 · 11 comments
Open

Checkstyle rules for Square's code style? #9

a11n opened this issue Mar 11, 2015 · 11 comments

Comments

@a11n
Copy link

a11n commented Mar 11, 2015

I like your code style. However, when reformatting my code using your style I am encountering various checkstyle violations for either Sun's or Google's default rules. It mostly complains about whitespaces before/after curly braces, line length and such stuff.

So my question is, if there exists a particular checkstyle-rules.xml for this style? Maybe it's a good idea to have both in place, code style along with dedicated check.

I've looked into the ones you are using in your projects, for instance Dagger, but actually it just omits some rules.

Thanks in advance.

@JakeWharton
Copy link
Collaborator

We don't have a standard one, no. I'd be open to creating one, but a little birdie told me of a tool which is coming out which might obviate the need for it.

@a11n
Copy link
Author

a11n commented Mar 16, 2015

Thanks so far for the information. Which tool are you referring to? :-) Any aprox. release date?

@dkozel
Copy link

dkozel commented May 1, 2015

I'm cleaning up an app at the moment and am also interested in a checkstyles implementation or this avian affiliated tool. Is any more information available? Thanks!

@cristiangarciascmspain
Copy link

@JakeWharton Any new on the tool you mention before?
I'm seen exactly that neither Square or you have a standard checkstyle, and what is more noticeable, newest project like RxAndroid doesn't have any...

@JakeWharton
Copy link
Collaborator

RxAndroid is not our project.

@johnjohndoe
Copy link

A dream would become reality if after such a long time a tool comes out which automates checkstyle synchronization between build tool and IDE. @JakeWharton I hope you are note joking.

@cristiangarciascmspain
Copy link

sorry, my mistake I was thinking on RxBinding.

but, anyway, any news about the tool?

@JakeWharton
Copy link
Collaborator

https://github.com/google/google-java-format/

On Tue, Nov 17, 2015 at 5:38 AM Cristian Garcia Marín <
[email protected]> wrote:

sorry, my mistake I was thinking on RxBinding.

but, anyway, any news about the tool?


Reply to this email directly or view it on GitHub
#9 (comment)
.

@secilgenc
Copy link

Hey, I am trying to find exactly checkstyle.xml for this style, SquareAndroid. If there exists a checkstyle.xml now, could you shared with me, please ?

Thank you

@janheinrichmerker
Copy link

@JakeWharton

[...] but a little birdie told me of a tool which is coming out which might obviate the need for it.

Any update on this? It's 2 years since that little bird told you a hint 😄 🐦

@JakeWharton
Copy link
Collaborator

JakeWharton commented Jun 5, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants