Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProductType is missing RESTAURANT #157

Open
jonlund opened this issue Feb 16, 2021 · 1 comment
Open

ProductType is missing RESTAURANT #157

jonlund opened this issue Feb 16, 2021 · 1 comment

Comments

@jonlund
Copy link

jonlund commented Feb 16, 2021

I'm getting device.code.paired webhook requests where the data.object.device_code.product_type is "RESTAURANT". The spec only has "TERMINAL_API" as an enum for ProductType.

(I hope this is helpful. I LOVE that you guys publish this api spec--I generated a swift API from it to use with my Vapor 4 backend. Awesome!!!)

{
    "created_at": "2021-01-27T21:12:22.326Z",
    "data": {
        "id": "XXXXXXXXXXXX",
        "object": {
            "device_code": {
                "code": "XXXXXXXXXXX",
                "created_at": "2021-01-27T21:11:53.000Z",
                "device_id": "DEVICE_INSTALLATION_ID:XXXXXXXXXXX",
                "id": "XXXXXXXXXXX",
                "location_id": "XXXXXXXXXXX",
                "name": "iPad5",
                "paired_at": "2021-01-27T21:12:16.000Z",
                "product_type": "RESTAURANT",
                "status": "PAIRED",
                "status_changed_at": "2021-01-27T21:12:16.000Z"
            }
        },
        "type": "device.code"
    },
    "event_id": "XXXXXXXXXXXXXXXXXXXXXXXXXX",
    "location_id": "XXXXXXXXXXX",
    "merchant_id": "XXXXXXXXXXX",
    "type": "device.code.paired"
}
@StephenJosey
Copy link

Thanks for sharing, I'll relay to the team. Note this shouldn't break any of our current SDKs as we should use strings instead of enums so that things like this won't break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants