-
Notifications
You must be signed in to change notification settings - Fork 24
Allow upgrade to Ruby 2.4 and JSON 2 #36
Allow upgrade to Ruby 2.4 and JSON 2 #36
Comments
Yes I believe some gems don't even require the dependency as it also causes on other platforms like Windows. I've seen this change go into libraries like Sidekiq. An update to allow json 1.8 or 2.0 would be greatly appreciated. |
The 1.8 branch of the JSON gem added support for Ruby 2.4+ in version 1.8.5. |
Even though it works as-is, I think it's a good idea to bump the JSON gem version! |
+1 - I am not able to start my app on Ruby 2.4.4 on Windows 10 when I include the
As soon as I remove the UPDATE: The issue wasn't Ruby 2.4.4. This solution to download |
THIS. Absolutely this. I'd love to be able to actually install/use square connect, but when it has dependencies that preclude running up to date versions of ruby, or having to run older versions of other gems, it's a complete non-starter. Is there some particular reason the JSON dependency is locked at an out of date version? |
Any update on this? |
Hello, There are at least two PRs referencing this and including my issue, 3. There is no reason to have 1.8.3 dependency. It makes upgrading to ruby 2.4, many of the rails ecosystem gems impossible. Can we get an update please? |
@v-kumar Hi! Apologies for the delay on this. The JSON gem version will be bumped in an upcoming release. |
@havenwood thanks! That would be most helpful. 😄 |
Closed by d5bcdca. |
This is awesome. Thanks @havenwood. |
json 2 is pretty much required now for full JSON RFC compliance and compatibility with ruby 2.4.
Most rails gems now support either 1.8 or 2.0.
Keeping the ceiling at 1.8 is preventing us from upgrading other gems and to ruby 2.4/2.5 versions. Can we be bit more generous with json dependency? This is similar to: Azure/autorest#476
Ruby 2.5 ships with json 2.1 and, Ruby 2.4 ships with json 2.0.x.
It would be better to skip the dependency altogether or support higher versions.
The text was updated successfully, but these errors were encountered: