Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

Allow upgrade to Ruby 2.4 and JSON 2 #36

Closed
v-kumar opened this issue Jun 10, 2018 · 11 comments · May be fixed by square/connect-api-specification#110
Closed

Allow upgrade to Ruby 2.4 and JSON 2 #36

v-kumar opened this issue Jun 10, 2018 · 11 comments · May be fixed by square/connect-api-specification#110

Comments

@v-kumar
Copy link

v-kumar commented Jun 10, 2018

json 2 is pretty much required now for full JSON RFC compliance and compatibility with ruby 2.4.

Most rails gems now support either 1.8 or 2.0.

Keeping the ceiling at 1.8 is preventing us from upgrading other gems and to ruby 2.4/2.5 versions. Can we be bit more generous with json dependency? This is similar to: Azure/autorest#476

Ruby 2.5 ships with json 2.1 and, Ruby 2.4 ships with json 2.0.x.

It would be better to skip the dependency altogether or support higher versions.

@javierjulio
Copy link

Yes I believe some gems don't even require the dependency as it also causes on other platforms like Windows. I've seen this change go into libraries like Sidekiq. An update to allow json 1.8 or 2.0 would be greatly appreciated.

@havenwood
Copy link
Collaborator

The 1.8 branch of the JSON gem added support for Ruby 2.4+ in version 1.8.5.

@havenwood
Copy link
Collaborator

Even though it works as-is, I think it's a good idea to bump the JSON gem version!

@adeeb1
Copy link

adeeb1 commented Jul 17, 2018

+1 - I am not able to start my app on Ruby 2.4.4 on Windows 10 when I include the square_connect gem because of the following error message:

C:/Ruby24-x64/lib/ruby/gems/2.4.0/gems/ffi-1.9.18-x64-mingw32/lib/ffi/library.rb:147:in `block in ffi_lib': Could not open library 'libcurl': The specif (LoadError)ould not be found.
.
Could not open library 'libcurl.dll': The specified module could not be found.
.
Could not open library 'libcurl.so.4': The specified module could not be found.
.
Could not open library 'libcurl.so.4.dll': The specified module could not be found.

..

As soon as I remove the square_connect gem from my project, everything works fine.

UPDATE:

The issue wasn't Ruby 2.4.4. This solution to download libcurl.dll and put it in my PATH worked for me.

@TranqTech
Copy link

THIS. Absolutely this. I'd love to be able to actually install/use square connect, but when it has dependencies that preclude running up to date versions of ruby, or having to run older versions of other gems, it's a complete non-starter. Is there some particular reason the JSON dependency is locked at an out of date version?

@v-kumar
Copy link
Author

v-kumar commented Oct 11, 2018

Any update on this?

@v-kumar
Copy link
Author

v-kumar commented Oct 13, 2018

Hello, There are at least two PRs referencing this and including my issue, 3. There is no reason to have 1.8.3 dependency. It makes upgrading to ruby 2.4, many of the rails ecosystem gems impossible. Can we get an update please?

@havenwood
Copy link
Collaborator

@v-kumar Hi! Apologies for the delay on this. The JSON gem version will be bumped in an upcoming release.

@javierjulio
Copy link

@havenwood thanks! That would be most helpful. 😄

@havenwood
Copy link
Collaborator

Closed by d5bcdca.

@v-kumar
Copy link
Author

v-kumar commented Oct 26, 2018

This is awesome. Thanks @havenwood.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants