`sqitch.conf` file permission mask

[fluca1978]

Using sqitch 1.4.1 from CPAN.
I noted that sqitch.conf has default read permission for everyone:

% sqitch --version
sqitch (App::Sqitch) v1.4.1

 % ls -l sqitch.conf
-rw-rw-r-- 1 luca luca 222 nov 19 09:41 sqitch.conf

Apparently the application is working even if permissions are set for only the user, thus:

% chmod 600 sqitch.conf

Shouldn't this be default permission mask since sqitch.conf could possibly contain connection passwords?

[theory]

Never thought about it. It defaults to whatever the current directory's umask is.

[theory]

Looks like Config::GitLike, which creates the file, does not have any support for custom permissions:

    sysopen(my $fh, "${filename}.lock", O_CREAT|O_EXCL|O_WRONLY)
        or die "Can't open ${filename}.lock for writing: $!\n";

Looks like it would require another attribute on the object, similar to encoding, to specify permissions to pass as the fourth argument to sysopen, something like:

sysopen(my $fh, "${filename}.lock", O_CREAT|O_EXCL|O_WRONLY, $self->permissions || 0666)

If they added such an option I'd be happy to use it in Sqitch.

[fluca1978]

Would it have sqitch to automatically adjust permissions at first read a possible solution?

[theory]

Or on first write, sure. Doesn't work for manually-created config files, though.

[fluca1978]

@theory PTAL at fluca1978@d4ab60e. Seems very simple solution to me, but works for both adding and editing configuration.
Clearly it makes extra work, since it checks that the configuration file(s) have the right permissions every time they are loaded, but at least it adjusts the permissions as soon as possible.
Clearly, there is no solution against a user that deliberately taint his own environment changing the permissions outside of the sqitch application.

[theory]

Config::GitLike operates on a whole chain of config files, including, potentially, files not owned by the current user. I think this should be limited to those owned by the current user, no?

How does Git deal with config file permissions?

[fluca1978]

Config::GitLike operates on a whole chain of config files, including, potentially, files not owned by the current user. I think this should be limited to those owned by the current user, no?

Good point! I guess, rethinking about this, that probably it does not have any sense to force permissions, since sqitch could use a globally defined file that, in turn, contains a set of target credentials that are shared, hence readable by different users.
Therefore, the only thing that could make sense, according to me, is to warn the user if the configuration file has world read access, letting her to change the permissions if appropriate.

How does Git deal with config file permissions?

I need to think about this and document, I have no idea so far.