Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide separate starters for client and server #90

Open
DanielLiu1123 opened this issue Jan 6, 2025 · 1 comment
Open

Provide separate starters for client and server #90

DanielLiu1123 opened this issue Jan 6, 2025 · 1 comment

Comments

@DanielLiu1123
Copy link

As mentioned in this comment, some services only depend on the gRPC client or server. Currently, spring-grpc only provides one starter. For these use cases, users need to manually add grpc-stub or grpc-services dependencies.

I think these are very two different use cases and it’s worth having spring-grpc provide two additional starters:

spring-grpc-client-spring-boot-starter # only client
spring-grpc-server-spring-boot-starter # only server

The existing starter should still be available, it includes both client and server starters:

spring-grpc-spring-boot-starter
├── spring-grpc-client-spring-boot-starter
└── spring-grpc-server-spring-boot-starter
@dsyer
Copy link
Collaborator

dsyer commented Jan 6, 2025

I'm not convinced that the grpc-services should be included yet. Personally I always use it, but wouldn't it be better to leave it as optional? We might end up with just 2 starters that way as well - there's no need for the combo because client is a superset of server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants