Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify build setup #82

Open
mhalbritter opened this issue Dec 18, 2024 · 4 comments
Open

Simplify build setup #82

mhalbritter opened this issue Dec 18, 2024 · 4 comments
Labels
question Further information is requested

Comments

@mhalbritter
Copy link
Contributor

mhalbritter commented Dec 18, 2024

Right now, users have to deal with various plugins and their configuration when using Spring gRPC (see the configuration generated on start.spring.io).

I'm not sure if it's technically possible, but maybe a Spring gRPC Maven and Gradle plugin could solve that problem.

That way, users only have to apply one plugin instead of multiple and dealing with their config.

@dsyer
Copy link
Collaborator

dsyer commented Dec 18, 2024

Nice idea. But I hate the thought of maintaining and publishing Maven and Gradle plugins that only do things that are already available elsewhere (albeit possibly with better defaults). For Maven wouldn't it be better just to include some default configuration in the parent? For Gradle I wouldn't know where to start, but there must be analogues (e.g. native image compilation - we don't have our own plugin for that do we).

@dsyer dsyer added the question Further information is requested label Dec 18, 2024
@mhalbritter
Copy link
Contributor Author

mhalbritter commented Dec 19, 2024

For Maven wouldn't it be better just to include some default configuration in the parent?

Yes. But as most projects have Spring Boot as their parent, you're limited to scope import, which doesn't support plugin configuration. Maven 4 fixes that I think.

For Gradle I wouldn't know where to start, but there must be analogues (e.g. native image compilation - we don't have our own plugin for that do we).

The Spring Boot plugin reacts to the application of the native plugin and re-configures the build.

@mhalbritter
Copy link
Contributor Author

mhalbritter commented Dec 19, 2024

The spring-grpc Gradle plugin could apply the com.google.protobuf plugin and configure it.

I'm not sure if it's possible, but the spring-grpc Maven plugin could add and configure the os-maven-plugin and the protobuf-maven-plugin (to work around the Maven limitations). No need to duplicate the existing plugins.

@dsyer
Copy link
Collaborator

dsyer commented Dec 19, 2024

I'm happy to wait and see if Spring Boot takes these responsibilities, so no need to do anything here for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants