Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors in integration tests on shutdown of client #47

Open
dsyer opened this issue Nov 6, 2024 · 2 comments
Open

Fix errors in integration tests on shutdown of client #47

dsyer opened this issue Nov 6, 2024 · 2 comments

Comments

@dsyer
Copy link
Collaborator

dsyer commented Nov 6, 2024 •
edited
Loading

I see some stack traces in tests sometimes because a context is closed before the client is shutdown. Not sure why, and it's mostly harmless, but it would be good to not see it.
@dsyer dsyer changed the title graceful shutdown client Graceful shutdown of client Nov 9, 2024
@CyberZujo
Copy link
Contributor

@dsyer Can I take this one?

@dsyer
Copy link
Collaborator Author

dsyer commented Nov 9, 2024

Sure. I don’t really know how to start. As far as I know we already shut the clients down. It might just be a test that needs fixing?

@dsyer dsyer closed this as completed Nov 10, 2024
@dsyer dsyer reopened this Nov 10, 2024
@dsyer dsyer changed the title Graceful shutdown of client Fix errors in integration tests on shutdown of client Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsyer @CyberZujo