Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a new API that abstracts away CommonsExecWebServerFactoryBean #44

Open
jgrandja opened this issue May 6, 2024 · 1 comment

Comments

@jgrandja
Copy link

jgrandja commented May 6, 2024

Given the following configuration:

@Bean
public CommonsExecWebServerFactoryBean authorizationServer() {
	return CommonsExecWebServerFactoryBean.builder()
		.mainClass(TestAuthorizationServerApplication.class.getName())
		.classpath((classpath) -> classpath
			.entries(MavenClasspathEntry.springBootStarter("oauth2-authorization-server"))
			.recursive(TestAuthorizationServerApplication.class)
		);
}

Can we consider a new API that abstracts away CommonsExecWebServerFactoryBean? I don't feel the CommonsExecWebServerFactoryBean is intuitive and is more of a technical implementation detail. I would prefer something as simple as WebServer.

@rwinch
Copy link
Collaborator

rwinch commented Aug 30, 2024

@jgrandja Can you create a ticket per proposal so we can discuss them in isolation? I don't want one discussion to block another? I also want to ensure we consider each change you are proposing.

NOTE: Feel free to use this ticket as one of the proposals if you like

@jgrandja jgrandja changed the title Consider API name changes Consider a new API that abstracts away CommonsExecWebServerFactoryBean Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants