Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logging of compile errors configurable #974

Open
3 tasks
fabapp2 opened this issue Oct 18, 2023 · 2 comments
Open
3 tasks

Make logging of compile errors configurable #974

fabapp2 opened this issue Oct 18, 2023 · 2 comments
Assignees
Labels
in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent revamp type: enhancement New feature or request

Comments

@fabapp2
Copy link
Contributor

fabapp2 commented Oct 18, 2023

What needs to be done

The logCompilationWarningsAndErrors flag of JavaParser.Builder should be configrable.
The flag should be provided through a new property parser.logCompilationWarningsAndErrors=[true|false]

Why it needs to be done

It allows users to turn on/off logging output of JavaCompiler which can be annoying in some cases and helpful in others.

Acceptance Criteria

  • The flag for the JavaParser.Builder created in MavenModuleParser is taken from ParserProperties
  • The property and it's usage is described README
  • A test provided. E.g. parse the same (erronous) class twice in an integration test, once with true once with false and assert the rendered output

Additional Information

@bsmahi
Copy link
Contributor

bsmahi commented Oct 18, 2023

Hi @fabapp2

I will work on it, could you please assign it to me.

Thanks,
Mahi

@fabapp2 fabapp2 added type: enhancement New feature or request in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent revamp labels Oct 18, 2023
@fabapp2
Copy link
Contributor Author

fabapp2 commented Oct 18, 2023

@bsmahi remember to branch from version/revamp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent revamp type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants