Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start adding error annotation #384

Closed
marcingrzejszczak opened this issue Aug 24, 2016 · 1 comment
Closed

Start adding error annotation #384

marcingrzejszczak opened this issue Aug 24, 2016 · 1 comment
Assignees
@marcingrzejszczak
Labels
enhancement
Milestone
1.0.11

Comments

@marcingrzejszczak
Copy link
Contributor

With Zipkin 1.3 https://github.com/openzipkin/zipkin/releases/tag/1.3.0 and openzipkin/zipkin#1140 error annotations can be resolved into a nice visualization in the UI.
@marcingrzejszczak marcingrzejszczak added this to the 1.1.0.M1 milestone Aug 24, 2016
@codefromthecrypt
Copy link
Contributor

here's some hints here openzipkin/openzipkin.github.io#52

main thing is that we shouldn't have a span dangling (ex only cr) as the span detail tab looks off.

@marcingrzejszczak marcingrzejszczak modified the milestones: 1.0.11, 1.1.0.M1 Oct 28, 2016
marcingrzejszczak added a commit that referenced this issue Oct 28, 2016
@marcingrzejszczak
Added error tag upon exceptions
addd6fb 
without this change there's no error colouring on Zipkin side
with this change we set error tags
- whenever there is an exception thrown on the server side (5xx)
- wheneber on the client side it's impossible to send a message

fixes #384
@marcingrzejszczak marcingrzejszczak self-assigned this Oct 28, 2016
marcingrzejszczak added a commit that referenced this issue Oct 28, 2016
@marcingrzejszczak
Added error tag upon exceptions
04410da 
without this change there's no error colouring on Zipkin side
with this change we set error tags
- whenever there is an exception thrown on the server side (5xx)
- wheneber on the client side it's impossible to send a message

fixes #384
marcingrzejszczak added a commit that referenced this issue Oct 31, 2016
@marcingrzejszczak
Added error tag upon exceptions
c05d8f6 
without this change there's no error colouring on Zipkin side
with this change we set error tags
- whenever there is an exception thrown on the server side (5xx)
- wheneber on the client side it's impossible to send a message

fixes #384
@marcingrzejszczak marcingrzejszczak mentioned this issue Oct 31, 2016
Merged
marcingrzejszczak added a commit that referenced this issue Oct 31, 2016
@marcingrzejszczak
Added error tag upon exceptions (#435)
538b5c9 
without this change there's no error colouring on Zipkin side
with this change we set error tags
- whenever there is an exception thrown on the server side (5xx)
- wheneber on the client side it's impossible to send a message

fixes #384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcingrzejszczak marcingrzejszczak

Labels
enhancement
Projects
None yet
Milestone
1.0.11
Development

No branches or pull requests
2 participants
@codefromthecrypt @marcingrzejszczak