Skip to content
This repository has been archived by the owner on May 31, 2022. It is now read-only.

TokenStore.readAccessToken and deserializeAccessToken called multiple times in case of valid token #1903

Open
rahulburangi opened this issue Dec 23, 2020 · 3 comments

Comments

@rahulburangi
Copy link

rahulburangi commented Dec 23, 2020

Summary

TokenStore.readAccessToken and TokenStore.deserializeAccessToken called multiple times in case of valid token. The multiple calls add the processing time and return timeout many time to the clients.

Actual Behavior

TokenStore.readAccessToken and TokenStore.deserializeAccessToken called multiple times in case of valid token. The multiple calls add the processing time and return timeout many time to the clients.
In case of invalidToken, tokenExpired and tokenNotFound the mentioned classes are called only one time. The observation is found by adding custom logs in implementing classes.

Expected Behavior

TokenStore.readAccessToken and TokenStore.deserializeAccessToken should be called only one time in case of valid tokens as well.

Configuration

Version

Version and Jar used: spring-security-oauth2-2.5.0.RELEASE.jar

Sample

@jgrandja
Copy link
Contributor

jgrandja commented Jan 4, 2021

@rahulburangi Would you be interested in submitting a PR for this performance improvement?

@spring-projects-issues
Copy link

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@spring-projects-issues
Copy link

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants