We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a result, we'll get Sending credit card numbers directly to the Stripe API is generally unsafe.
Sending credit card numbers directly to the Stripe API is generally unsafe
So, the problem in JS.
We have this:
Spree.stripePaymentMethod = $('#payment_method_' + 3);
And later:
if Spree.stripePaymentMethod.is(':visible')
And last one returns false in Chrome console, when this payment method is actually visible and $('payment_method_3').is(':visible') returns true.
false
$('payment_method_3').is(':visible')
true
This is well-known jQuery problem/feature of selectors snapshots - https://stackoverflow.com/questions/11868899/how-can-i-refresh-a-stored-and-snapshotted-jquery-selector-variable
Maybe to store in Spree.stripePaymentMethod just a selector string, not a snapshot?
Spree.stripePaymentMethod
The text was updated successfully, but these errors were encountered:
No branches or pull requests
As a result, we'll get
Sending credit card numbers directly to the Stripe API is generally unsafe
.So, the problem in JS.
We have this:
And later:
And last one returns
false
in Chrome console, when this payment method is actually visible and$('payment_method_3').is(':visible')
returnstrue
.This is well-known jQuery problem/feature of selectors snapshots - https://stackoverflow.com/questions/11868899/how-can-i-refresh-a-stored-and-snapshotted-jquery-selector-variable
Maybe to store in
Spree.stripePaymentMethod
just a selector string, not a snapshot?The text was updated successfully, but these errors were encountered: