Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product#meta_description should not fall back to a different locale #641

Open
mvz opened this issue Oct 15, 2015 · 1 comment
Open

Product#meta_description should not fall back to a different locale #641

mvz opened this issue Oct 15, 2015 · 1 comment

Comments

@mvz
Copy link

mvz commented Oct 15, 2015

Plain Spree uses description as a fallback for meta_description to provide one of the meta-data tags in the header. As such, in the case of a missing translation when using spree_i18n, it makes more sense to show the description field for the same locale than fall back to a different locale.

Therefore, for this particular field, I think there should not be a fallback to a different locale.

@alepore
Copy link
Member

alepore commented Oct 15, 2015

Yeah, make sense, feel free to open a PR for this (on spree_globalize)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants