From e8d03bb8cc739a0be9da4cadcfc76ce0ce904e95 Mon Sep 17 00:00:00 2001
From: Artem Rys <rysartem@gmail.com>
Date: Wed, 27 Nov 2024 15:59:46 +0100
Subject: [PATCH] chore(appinspect-api): make it pass (#1491)

**Issue number:** N/A

### PR Type

**What kind of change does this PR introduce?**
* [ ] Feature
* [ ] Bug Fix
* [ ] Refactoring (no functional or API changes)
* [ ] Documentation Update
* [x] Maintenance (dependency updates, CI, etc.)

## Summary

### Changes

* Updating license path in "everything" add-on to pass AppInspect API
check.
* Removed `check_for_compiled_python` known issue from ignore file.
* Run `appinspect-api` for every PR.

### User experience

N/A

## Checklist

If an item doesn't apply to your changes, leave it unchecked.

* [x] I have performed a self-review of this change according to the
[development
guidelines](https://splunk.github.io/addonfactory-ucc-generator/contributing/#development-guidelines)
* [ ] Tests have been added/modified to cover the changes [(testing
doc)](https://splunk.github.io/addonfactory-ucc-generator/contributing/#build-and-test)
* [ ] Changes are documented
* [x] PR title and description follows the [contributing
principles](https://splunk.github.io/addonfactory-ucc-generator/contributing/#pull-requests)
---
 .github/workflows/build-test-release.yml                       | 3 +--
 .../.appinspect_api.expect.yaml                                | 2 --
 .../package_global_config_everything/package/app.manifest      | 2 +-
 3 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/build-test-release.yml b/.github/workflows/build-test-release.yml
index 495d32f30..0afc0b68d 100644
--- a/.github/workflows/build-test-release.yml
+++ b/.github/workflows/build-test-release.yml
@@ -325,8 +325,7 @@ jobs:
     needs: build-test-addon
     if: |
       !cancelled() &&
-      needs.build-test-addon.result == 'success' &&
-      ( github.base_ref == 'main' || github.ref_name == 'main' )
+      needs.build-test-addon.result == 'success'
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
diff --git a/tests/testdata/expected_addons/expected_output_global_config_everything/.appinspect_api.expect.yaml b/tests/testdata/expected_addons/expected_output_global_config_everything/.appinspect_api.expect.yaml
index d57b094a2..e69de29bb 100644
--- a/tests/testdata/expected_addons/expected_output_global_config_everything/.appinspect_api.expect.yaml
+++ b/tests/testdata/expected_addons/expected_output_global_config_everything/.appinspect_api.expect.yaml
@@ -1,2 +0,0 @@
-check_for_compiled_python:
-  comment: 'Expected failure as compiled python file was detected in your build.'
\ No newline at end of file
diff --git a/tests/testdata/test_addons/package_global_config_everything/package/app.manifest b/tests/testdata/test_addons/package_global_config_everything/package/app.manifest
index e42e5a046..c947b9b82 100644
--- a/tests/testdata/test_addons/package_global_config_everything/package/app.manifest
+++ b/tests/testdata/test_addons/package_global_config_everything/package/app.manifest
@@ -24,7 +24,7 @@
     "commonInformationModels": null,
     "license": {
       "name": null,
-      "text": "LICENSES/Apache-2.0.txt",
+      "text": "LICENSES/Apache License 2.0.txt",
       "uri": null
     },
     "privacyPolicy": {