You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This generated block in react-notion.esm.js is failing when properties are null. Properties are not always present in this case and therefore there can be a failure here with .caption in the chain. I'm not sure the best way to handle this - is the onus on the notion doc creator to ensure no null properties values? (this could happen if an unfinished video component was inserted in a doc and mistakenly forgotten about).
Should properties be required on ContentValueType? on All values?
Should properties be required? Can we make them nullable, or is that an antipattern?
The text was updated successfully, but these errors were encountered:
jeanmw
changed the title
Handling null property values
Handling null properties values
Aug 16, 2022
This generated block in react-notion.esm.js is failing when properties are null. Properties are not always present in this case and therefore there can be a failure here with
.caption
in the chain. I'm not sure the best way to handle this - is the onus on the notion doc creator to ensure no null properties values? (this could happen if an unfinished video component was inserted in a doc and mistakenly forgotten about).Should properties be required on
ContentValueType
? on All values?Should properties be required? Can we make them nullable, or is that an antipattern?
The text was updated successfully, but these errors were encountered: