Merge pull request #43 from spinkube/shim-tests

Shim tests

Author: toksikk

internal/shim/install_test.go

@@ -46,6 +46,21 @@ func TestConfig_Install(t *testing.T) {
 		want    wants
 		wantErr bool
 	}{
+		{
+			"successful shim installation",
+			fields{
+				tests.FixtureFs("../../testdata/node-installer"),
+				afero.NewMemMapFs(),
+				"/assets",
+				"/opt/kwasm",
+			},
+			args{"containerd-shim-slight-v1"},
+			wants{
+				"/opt/kwasm/bin/containerd-shim-slight-v1",
+				true,
+			},
+			false,
+		},
 		{
 			"no changes to shim",
 			fields{

internal/shim/uninstall.go

@@ -27,9 +27,8 @@ func (c *Config) Uninstall(shimName string) (string, error) {
 		}
 		slog.Warn("shim binary did not exist, nothing to delete")
 	}
-
 	st.RemoveShim(shimName)
-	if err := st.Write(); err != nil {
+	if err = st.Write(); err != nil {
 		return "", err
 	}
 	return filePath, err

internal/shim/uninstall_test.go

@@ -0,0 +1,90 @@
+/*
+   Copyright The KWasm Authors.
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+*/
+
+package shim //nolint:testpackage // whitebox test
+
+import (
+	"testing"
+
+	"github.com/spf13/afero"
+	tests "github.com/spinkube/runtime-class-manager/tests/node-installer"
+)
+
+func TestConfig_Uninstall(t *testing.T) {
+	type fields struct {
+		hostFs    afero.Fs
+		kwasmPath string
+	}
+	type args struct {
+		shimName string
+	}
+	tests := []struct {
+		name    string
+		fields  fields
+		args    args
+		want    string
+		wantErr bool
+	}{
+		{
+			"shim not installed",
+			fields{
+				tests.FixtureFs("../../testdata/node-installer/shim"),
+				"/opt/kwasm",
+			},
+			args{"not-existing-shim"},
+			"",
+			false,
+		},
+		{
+			"missing shim binary",
+			fields{
+				tests.FixtureFs("../../testdata/node-installer/shim-missing-binary"),
+				"/opt/kwasm",
+			},
+			args{"spin-v1"},
+			"/opt/kwasm/bin/containerd-shim-spin-v1",
+			false,
+		},
+		{
+			"successful shim uninstallation",
+			fields{
+				tests.FixtureFs("../../testdata/node-installer/shim"),
+				"/opt/kwasm",
+			},
+			args{"spin-v1"},
+			"/opt/kwasm/bin/containerd-shim-spin-v1",
+			false,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			c := &Config{
+				hostFs:    tt.fields.hostFs,
+				kwasmPath: tt.fields.kwasmPath,
+			}
+
+			got, err := c.Uninstall(tt.args.shimName)
+
+			if (err != nil) != tt.wantErr {
+				t.Errorf("Config.Uninstall() error = %v, wantErr %v", err, tt.wantErr)
+				return
+			}
+			if got != tt.want {
+				t.Errorf("Config.Uninstall() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}

testdata/node-installer/shim-missing-binary/opt/kwasm/kwasm-lock.json

@@ -0,0 +1,8 @@
+{
+ "shims": {
+  "spin-v1": {
+   "sha256": "6da5e8f17a9bfa9cb04cf22c87b6475394ecec3af4fdc337f72d6dbf3319ea52",
+   "path": "/opt/kwasm/bin/containerd-shim-spin-v1"
+  }
+ }
+}

tests/node-installer/fs.go

@@ -1,11 +1,38 @@
 package tests
 
 import (
+	"io"
+	"os"
+
 	"github.com/spf13/afero"
 )
 
 func FixtureFs(fixturePath string) afero.Fs {
 	baseFs := afero.NewBasePathFs(afero.NewOsFs(), fixturePath)
-	fs := afero.NewCopyOnWriteFs(baseFs, afero.NewMemMapFs())
+	fs := afero.NewMemMapFs()
+	err := afero.Walk(baseFs, "/", func(path string, info os.FileInfo, err error) error {
+		if err != nil {
+			return err
+		}
+		if info.IsDir() {
+			return fs.MkdirAll(path, 0755) //nolint:gomnd // file permissions
+		}
+		src, err := baseFs.Open(path)
+		if err != nil {
+			return err
+		}
+		dst, err := fs.Create(path)
+		if err != nil {
+			return err
+		}
+		_, err = io.Copy(dst, src)
+		if err != nil {
+			return err
+		}
+		return nil
+	})
+	if err != nil {
+		panic(err)
+	}
 	return fs
 }