Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pod not-ready causes webhook call failure #4280

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ty-dc
Copy link
Collaborator

@ty-dc ty-dc commented Nov 11, 2024

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #4277

Special notes for your reviewer:

  1. 在重启工作节点后,新的 Pod 必须先运行,才会终结旧的 spiderpool-controller Pod,而由于端口占用的问题,新的 spiderpool-controller pod 永远不会 running,一直都是 Pending 的。故将 spiderpool-controller deploy 的 maxSurge 设置为 0 后,让 Pod 先终结在运行新的 spiderpool-controller Pod 。但是它会依次重启每一个副本 Pod,在用例原本逻辑中,只检查了 worker 节点上的 Pod webhook 。导致有概率出现 control-plane 上的 Pod 还没有 1/1,而是 0/1。影响其他 case 创建 Pod。

  2. 优化 deferCleanup 和 BeforeEach,将一些代码顺序变更。

@ty-dc ty-dc added release/none no release note cherrypick-release-v1.0 Cherry-pick the PR to branch release-v1.0. labels Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.60%. Comparing base (364fb54) to head (e1d6c17).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4280      +/-   ##
==========================================
+ Coverage   79.55%   79.60%   +0.04%     
==========================================
  Files          53       53              
  Lines        6252     6252              
==========================================
+ Hits         4974     4977       +3     
+ Misses       1085     1083       -2     
+ Partials      193      192       -1     
Flag Coverage Δ
unittests 79.60% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick-release-v1.0 Cherry-pick the PR to branch release-v1.0. release/none no release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly K8s Matrix CI 2024-11-09: Failed
1 participant