api: update enableRdma/rdmaIsolation field for spiderMultusConfig #4301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyclinder
requested review from
weizhoublue,
ty-dc,
bzsuni and
windsonsea
as code owners
cyclinder
force-pushed
the
spidermultusconfig/api_update
branch
3 times, most recently
from
1e0f7cd
to
4dee59d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4301 +/- ##
=======================================
Coverage 79.51% 79.52%
=======================================
Files 53 53
Lines 6252 6255 +3
=======================================
+ Hits 4971 4974 +3
Misses 1088 1088
Partials 193 193
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: cyclinder <[email protected]>
cyclinder
force-pushed
the
spidermultusconfig/api_update
branch
from
4dee59d
to
fd7b567
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
Notice:
"release/none"
"release/bug"
"release/feature"
What issue(s) does this PR fix:
Fixes #4267
Special notes for your reviewer:
Remove enableRdma field for macvlan and ipvlan CNI
Make the enableRdma field DEPRECATED for sriov-cni, and use rdmaIsolation instead. which keep consistant with ibsriov-cni.
Update the comments of the spiderMultusConfig fields and docs.