-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prompt users to open Readme on developer's request #346
Comments
@kyrie25 Rather than having it open up the entire readme, could we instead allow the extension/theme owners to open any .MD file in the repo to allow more room for customization, we can simply have an optional parameter in the manifest titled "special-instructions" or "force-open" or something of the like. |
The general idea is that it prevents themes/extensions breaking from installing on Marketplace so yeah whichever works. |
What doesn't work when installed via marketplace? Themes have the "include" array to bundle extensions in them. |
Ah, right, didn't think of that. I think it's probably easier to support just having it open externally and make them install via cli. Otherwise you'll have people with weird hybrids |
📝 Provide a description of the new feature
There are currently themes and extensions that has this issue (eg. Dribbblish Dynamic) where the users are required to install the theme/extension locally or to take extra steps before installing, and that Marketplace installation doesn't work properly for them.
In order for theme/extension developers to not feel discouraged from publishing to Marketplace, I'd suggest making an additional field on the manifest format that requests Marketplace to open its Readme and read the requirements before installing (boolean value).
➕ Additional Information
Currently I can think of a few ways to do this:
Install
button on Cards to the GitHub icon, on click it would prompt the user with a modal which would open the Readme externally (on their browser etc.).This means that users will have to install said theme/extension via the CLI.
This means that users can still install said theme/extension via Marketplace, and the extension/theme devs can include whether it should be installed Marketplace or not.
The text was updated successfully, but these errors were encountered: