Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add a hotkey for hiding/displaying the song metadata info column #50

Open
xxxserxxx opened this issue Sep 26, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@xxxserxxx
Copy link
Collaborator

Depends on #46 being merged.

@spezifisch spezifisch added this to the v1.0.0 milestone Oct 13, 2024
@spezifisch spezifisch added the enhancement New feature or request label Oct 13, 2024
@xxxserxxx
Copy link
Collaborator Author

I do not know if this can be accomplished with tview; that is, I don't see a way to hide individual GUI elements. The hiding/showing functionality appears to be available for pages, and for modals.

I can think of three work-arounds:

  1. Dynamically removing (deleting) on hide, and re-creating and re-adding the element on show. I feel uncertain about how tview's layout mechanism will handle this, but I think it'd work. Managing all of the plumbing might be challenging.
  2. Create two queue pages, one with a song info panel, and one without, and swap between them. I'm sure this could be done with the tview ABI, but have similar concerns as the previous option about the complexity of ensuring that everything is plumbed properly when switches happen.
  3. Have this not be toggle-able, but configurable. That is, depending on the initialization runtime options, optionally add and plumb the song info. It'd be on by default, but Users could to turn it off on constrained environments.

#3 is the easiest, and would probably be sufficient for most use cases. As I've said before, I imagine there would be fewer people wanting to turn it on and off dynamically; more likely is that they're running in a small VT and don't have space for the song info column, or they're running on restricted memory systems and turning off the song info would prevent any cover art image data from being loaded.

@spezifisch , what do you think?

@spezifisch
Copy link
Owner

Yes, 3 sounds good!

PS: What happens if we resize the widget to zero width or height?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants