Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selected entry gets stuck #33

Closed
spezifisch opened this issue Aug 24, 2024 · 5 comments · Fixed by #75
Closed

selected entry gets stuck #33

spezifisch opened this issue Aug 24, 2024 · 5 comments · Fixed by #75
Labels
bug Something isn't working
Milestone

Comments

@spezifisch
Copy link
Owner

(dev branch)

I had it happen that the first song of the queue was selected, i focused the terminal and couldn't move the selected line with up/down arrows.

Workaround: Click with mouse to select another entry. First entry works normally after that.

Possibly related to the commit where the -1 bounds check was added.

@spezifisch spezifisch added the bug Something isn't working label Aug 24, 2024
@spezifisch spezifisch added this to the v1.0.0 milestone Aug 24, 2024
@xxxserxxx
Copy link
Collaborator

Can you describe the steps to reproduce this? It's not something I've come across. Which commit do you think may have caused it? I'll look into it, whether or not I introduced it :-)

Is it possible it is related to an interaction with the terminal you use, or are you able to reproduce it in other terminals?

@xxxserxxx
Copy link
Collaborator

@spezifisch Poke. Is this still an issue? Can you describe how to reproduce it?

@spezifisch
Copy link
Owner Author

@spezifisch Poke. Is this still an issue? Can you describe how to reproduce it?

Yes, it's reproducible using mouse support in a terminal, I'm using alacritty but it shouldn't matter.

To reproduce:

  • play a song
  • click somewhere on the "Playing ... by ..." text.
  • arrow keys and others get trapped because that textbox is probably now focused

This problem should be addressed through #31.

@spezifisch
Copy link
Owner Author

Maybe this tview method will be useful:

func (b *Box) WrapMouseHandler(...)

@xxxserxxx
Copy link
Collaborator

I've reproduced it. This is a systemic problem for any widgets that don't have input handlers; it affects the song info widget as well, as it's purely informational.

xxxserxxx added a commit that referenced this issue Oct 15, 2024
xxxserxxx added a commit to xxxserxxx/stmps that referenced this issue Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants