From 63fcb2769edd6449b912742985323dbfdc3f5573 Mon Sep 17 00:00:00 2001 From: PHILO-HE Date: Thu, 12 Dec 2024 10:30:08 -0800 Subject: [PATCH] build: Remove test component of lib icu (#11826) Summary: The test component of lib icu is not used in Velox. This pr simply removes it, assuming there is no reason for keeping it. Pull Request resolved: https://github.com/facebookincubator/velox/pull/11826 Reviewed By: xiaoxmeng Differential Revision: D67119218 Pulled By: kgpai fbshipit-source-id: a1a91e2e6c07ce699b2c23bf999ef0793070bd38 --- CMake/resolve_dependency_modules/icu.cmake | 3 +-- CMake/resolve_dependency_modules/icu/FindICU.cmake | 7 ++++++- CMakeLists.txt | 3 +-- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/CMake/resolve_dependency_modules/icu.cmake b/CMake/resolve_dependency_modules/icu.cmake index ac002d2f389b..59f7f4eb0835 100644 --- a/CMake/resolve_dependency_modules/icu.cmake +++ b/CMake/resolve_dependency_modules/icu.cmake @@ -70,8 +70,7 @@ set(icu_components i18n io uc - tu - test) + tu) foreach(component ${icu_components}) add_library(ICU::${component} SHARED IMPORTED) diff --git a/CMake/resolve_dependency_modules/icu/FindICU.cmake b/CMake/resolve_dependency_modules/icu/FindICU.cmake index 43fdc8408695..15413ecc415d 100644 --- a/CMake/resolve_dependency_modules/icu/FindICU.cmake +++ b/CMake/resolve_dependency_modules/icu/FindICU.cmake @@ -13,7 +13,12 @@ # limitations under the License. message("Using ICU - Bundled") set(ICU_FOUND TRUE) -set(icu_components data i18n io uc tu test) +set(icu_components + data + i18n + io + uc + tu) foreach(component icu_components) set(ICU_${component}_FOUND TRUE) endforeach() diff --git a/CMakeLists.txt b/CMakeLists.txt index 9de9f5a08e48..34ac58b7d7e6 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -427,8 +427,7 @@ velox_resolve_dependency( i18n io uc - tu - test) + tu) set(BOOST_INCLUDE_LIBRARIES atomic