Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Title field to webpages so that tab names are more descriptive #34

Open
bmorrissirromb opened this issue Dec 11, 2023 · 6 comments · May be fixed by #42
Open

Add the Title field to webpages so that tab names are more descriptive #34

bmorrissirromb opened this issue Dec 11, 2023 · 6 comments · May be fixed by #42

Comments

@bmorrissirromb
Copy link

Previously,

All Tabroom.com web instances appeared identical in tabbed browsing, each displaying the generic label Tabroom.com.

image

If you had several tabs open, this made it extremely difficult to select the right one. It also makes it hard to return to a closed tab via browser history, since the Title is indexed in most browser histories, but it's only indexing Tabroom.com instead of any useful information. So typically, users need to re-navigate the whole site instead of just typing "Glenbrooks" or something to get back to where they were.

Now,

Major Tabroom subpages have titles that reflect their purpose.

image

  • Tournament splash/"invite" pages: <Name of Tournament>
  • Results pages: Results - <Event Name> - <Round Name> - <Tournament Name>
  • Pairings pages: Pairings - <Event Name> - <Round Name> - <Tournament Name>
  • Entries pages: Entries - <Event Name> - <Tournament Name>
  • Judges pages: Judges - <Tournament Name>

There's probably others that could use a descriptive name, but these are probably the biggest "bang for your buck" pages.

@bmorrissirromb
Copy link
Author

@palmertab - Let me know if there's a better way to submit issues for UX stuff like this, or whether you'd want PRs to try to implement this or not. I want to help Tabroom improving, but recognize that you have a shit ton of competing priorities.

@benjmor
Copy link

benjmor commented Jan 23, 2024

Okay, so there's actually some interesting stuff happening here. The setup and register subpages will display descriptive titles, but most tourn subpages will not. This is likely due to the $tourn variable not being populated for them.

This is the block that controls what the title of ALL Tabroom webpages will be:

<title>

Now to see what it would take to get that populated...

@benjmor
Copy link

benjmor commented Jan 23, 2024

The $tourn variable should be populated a little bit after the Tab::Tourn object is created.

https://github.com/speechanddebate/tabroom/blob/master/web/lib/Tab/Tourn.pm

There doesn't seem to be a retrieve method within Tab:Tourn. Maybe it's inherited? Checking...

@benjmor
Copy link

benjmor commented Jan 23, 2024

Ok, so retrieve is coming from Class:DBI which is some Perl built-in. Fun.

Time to do some inference on whether it's $tourn not being populated or whether the start property is missing.

@benjmor
Copy link

benjmor commented Jan 23, 2024

Issue is definitely that $tourn is not being populated for typical tourn webpages...

@benjmor
Copy link

benjmor commented Jan 23, 2024

All righty. So, $tourn is apparently a special variable, used to access tournament specific data and not to be messed with!

We should instead update the autohandler in subpages that need more descriptive titles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants