Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OFFICIAL BREAKING-CHANGES NOTIFICATION THREAD #321

Open
tabatkins opened this issue Jan 13, 2015 · 6 comments
Open

OFFICIAL BREAKING-CHANGES NOTIFICATION THREAD #321

tabatkins opened this issue Jan 13, 2015 · 6 comments

Comments

@tabatkins
Copy link
Collaborator

This is the official announcement thread for breaking changes. If you'd like to be informed about breaking changes, subscribe to this thread.

domenic added a commit to whatwg/streams that referenced this issue Jan 30, 2015
@tabatkins tabatkins changed the title Discussing breaking changes OFFICIAL BREAKING-CHANGES NOTIFICATION THREAD Jun 23, 2015
@tabatkins tabatkins pinned this issue Feb 15, 2019
@tabatkins
Copy link
Collaborator Author

tabatkins commented Mar 19, 2020

And... Bikeshed is now a Python 3 project. It'll now print out a nice refusal message if you try to run it on Py2.

Install instructions forthcoming, but the most relevant bit is that it requires Python 3.7; this isn't the default py3 install on many OSes, so I recommend using pyenv to install it. Here's a tutorial.

If you still need to use the py2 version, I published a tag with the last py2 commit. You can get that version specifically with:

git clone https://github.com/tabatkins/bikeshed.git -b v0.9

This won't update again, tho, so it's in your best interest to update your Python anyway.

If you're using Bikeshed on CI, updating should be trivial; telling Travis or GitHub to use Python 3.7 is just a config option, like in https://github.com/tabatkins/bikeshed/blob/master/.travis.yml

ngzhian added a commit to ngzhian/spec that referenced this issue Mar 24, 2020
ngzhian added a commit to WebAssembly/spec that referenced this issue Mar 24, 2020
* Set travis env to Python 3.7

Bikeshed requires 3.7, see
speced/bikeshed#321 (comment)

* Fix import of queue for python3

* Missed 1 more Queue

* Update shebangs to python3
gumb0 pushed a commit to wasmx/wasm-spec that referenced this issue Sep 21, 2020
* Set travis env to Python 3.7

Bikeshed requires 3.7, see
speced/bikeshed#321 (comment)

* Fix import of queue for python3

* Missed 1 more Queue

* Update shebangs to python3
@tabatkins
Copy link
Collaborator Author

@frivoal just pushed a very nice set of commits improving various little bits of the <wpt> element, most notably the new WPT Display: closed value and associated styles. When this is turned on, the <wpt> element is a <details> that starts closed, with the summary being a small, out-of-the-way little "TESTS" that doesn't visually interrupt at all.

This is looking so good that I think I'll flip it to the default soon, for non-TR documents. If you're currently use <wpt> and definitely do not want tests to show in your document, add a WPT Display: none metadata to your spec or your group's defaults.include file.

We flipped it on by default in the CSSWG just a few minutes ago, so in a little bit (once everything regens) you'll be able to see how it looks on any CSSWG spec - I recommend checking Color 4 and searching for "tests".

@svgeesus
Copy link
Contributor

This is looking so good that I think I'll flip it to the default soon, for non-TR documents.

I would prefer to see them like this on /TR documents, too.

@tabatkins
Copy link
Collaborator Author

Ah yeah it's been nearly a year and the experience has been great, I'll just flip the default

@tabatkins
Copy link
Collaborator Author

As part of my quest to add typing hints to all of Bikeshed, I'm also ending up refreshing some old confusing code that dates back to my earliest implementation. Most recently, I did a decent rewrite of my biblio handling, which will likely cause some changes - in particular, I believe I now correctly handle the Default Biblio Status metadata (and its default, which is based on your spec's Status) in all places, which from the testsuite diff will probably affect a lot of references, switching them from snapshots to EDs or vice versa.

If anything looks wrong, please let me know.

@frivoal
Copy link
Contributor

frivoal commented May 16, 2024

Notice of breaking change, effective for a while already and documented in #1773 (comment):
The ABSTRACTATTR macro is no longer supported by bikeshed. If you use that in your templates or documents, they need updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants