-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strange rendering/scrollable IDL boxes #2861
Comments
You're looking at a spec that hasn't been regenerated in 3 years. The popup code has been significantly improved since then. ^_^ |
Thanks for fixing that (even if long ago, lol!) 🥰 |
No, I generated it locally, and the dom structure isn't even compatible with that rendering - they're generated on the fly and as children of body, now. In the version you linked to they're all pregenerated, as children of the dfns, which is how I used to render them. I guess they're using an old Bikeshed to do the generation. |
Yeah, that structure was entirely changed as part of the 4.0 update #1773 (comment) But it looks like they're using specprod https://github.com/w3c/webappsec-credential-management/blob/main/.github/workflows/auto-publish.yml so I'm just really confused about this. |
@sidvishnoi, any ideas on the Specprod side? |
From latest action run there:
That workflow is using ubuntu-20.04, instead of ubuntu-latest, so they end up using old python, which I think, in turn leads to old bikeshed being used. TIL pipx from Bikeshed docs. Might use in spec-prod. |
Ok cool. I’ll get that fixed over in the other repo. |
Phew, thanks for debugging this, it'll help a lot of people. |
We should maybe do a search to see if other repos are affected. Should we keep this open as a reminder? |
FYI we just ran into this in WICG/cookie-store and fortunately I remembered seeing this issue. I just fixed it there and checked repos I've touched recently. I directly fixed WICG/entries-api, WICG/local-font-access, and w3c/web-locks and filed PRs for webmachinelearning/webnn and w3c/window-management so... it's likely very widespread. |
Reopening so we remember to do a search. |
I can probably add a warning to spec-prod when using older Ubuntu. |
When clicking on the definition for a IDL construct (e.g., interface) the container suddenly becomes scrollable and the references box goes gets culled:
Try it here by clicking on
CredentialRequestOptions
:https://w3c.github.io/webappsec-credential-management/#credentialrequestoptions-dictionary
Worst case scenario, it end up like this:
Expected the DFN box to be on top and not inside the IDL box.
The text was updated successfully, but these errors were encountered: